Implement `&pin` patterns and `ref pin` binding modes #148397

Looks very good! The policy about rustfmt is that we don't change formatting on our side when we add new syntax but I would feel silly asking you to revert your change; I'm leaving it in.

@bors r+ rollup=iffy

bors · 2025-11-09T14:53:28Z

📌 Commit cd14a39 has been approved by Nadrieril

It is now in the queue for this repository.

Implement `&pin` patterns and `ref pin` binding modes Implement `&pin` patterns and `ref pin` binding modes, part of [pin ergonomics](#130494). r? `@Nadrieril` cc `@traviscross` `@eholk`

bors · 2025-11-09T16:35:16Z

⌛ Testing commit cd14a39 with merge 40fefc8...

bors · 2025-11-09T16:43:23Z

💔 Test failed - checks-actions

rustbot · 2025-11-10T02:04:42Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

frank-king · 2025-11-10T04:07:49Z

The policy about rustfmt is that we don't change formatting on our side when we add new syntax

Wouldn't that break the fmt check of tidy test in our UI tests? (unless with #[rustfmt::skip])

traviscross

Looks good to me also. Thanks @frank-king.

View changes since this review

traviscross · 2025-11-10T08:24:50Z

@bors r=Nadrieril,traviscross rollup=iffy

bors · 2025-11-10T08:24:52Z

📌 Commit 5ef48ed has been approved by Nadrieril,traviscross

It is now in the queue for this repository.

bors · 2025-11-10T08:24:53Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Nadrieril · 2025-11-10T12:36:37Z

Wouldn't that break the fmt check of tidy test in our UI tests? (unless with #[rustfmt::skip])

The idea is not that rustfmt would error, it's that it would leave the code unformatted, exactly as if rustfmt::skip had been passed to whatever node contains the new syntax.

bors · 2025-11-10T18:57:01Z

⌛ Testing commit 5ef48ed with merge 29a6971...

bors · 2025-11-10T22:10:40Z

☀️ Test successful - checks-actions
Approved by: Nadrieril,traviscross
Pushing 29a6971 to main...

github-actions · 2025-11-10T22:13:46Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 055d0d6 (parent) -> 29a6971 (this PR)

Test differences

Show 74 test diffs

Stage 1

[ui] tests/ui/pin-ergonomics/pin-pattern.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/pin-ergonomics/pin-pattern.rs: [missing] -> pass (J1)

Additionally, 72 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 29a69716f2c0f19b5f9163bb4d8c50fb818cf326 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 8817.3s -> 5794.6s (-34.3%)
tidy: 142.7s -> 169.9s (+19.0%)
aarch64-msvc-2: 4634.0s -> 5286.3s (+14.1%)
x86_64-gnu-tools: 3264.2s -> 3715.2s (+13.8%)
aarch64-apple: 10654.8s -> 9396.5s (-11.8%)
dist-riscv64-linux: 4790.2s -> 5284.2s (+10.3%)
dist-ohos-x86_64: 4623.0s -> 4186.7s (-9.4%)
x86_64-gnu-stable: 6949.2s -> 7514.9s (+8.1%)
dist-arm-linux-musl: 5260.6s -> 5675.9s (+7.9%)
x86_64-gnu-llvm-20-2: 5834.3s -> 6274.5s (+7.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-10T23:30:18Z

Finished benchmarking commit (29a6971): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	[1.1%, 1.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -5.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.3%	[-5.3%, -5.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-5.3%	[-5.3%, -5.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.7s -> 477.532s (0.17%)
Artifact size: 391.36 MiB -> 391.38 MiB (0.01%)

…drieril,traviscross Implement `&pin` patterns and `ref pin` binding modes Implement `&pin` patterns and `ref pin` binding modes, part of [pin ergonomics](rust-lang#130494). r? `@Nadrieril` cc `@traviscross` `@eholk` Signed-off-by: Voxell Paladynee <paladyneshadow@gmail.com>

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 2, 2025

This comment has been minimized.

Sign in to view

frank-king force-pushed the feature/pin-pattern branch from 2df8a82 to 47329dc Compare November 5, 2025 12:52

frank-king changed the title ~~[WIP] implement pin patterns~~ Implement &pin patterns and ref pin binding modes Nov 5, 2025

This comment has been minimized.

Sign in to view

frank-king force-pushed the feature/pin-pattern branch from 47329dc to 039929c Compare November 6, 2025 03:31

rustbot added T-clippy Relevant to the Clippy team. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. labels Nov 6, 2025

This comment has been minimized.

Sign in to view

frank-king force-pushed the feature/pin-pattern branch 2 times, most recently from 2512da9 to d001988 Compare November 6, 2025 06:04

This comment has been minimized.

Sign in to view

frank-king force-pushed the feature/pin-pattern branch from d001988 to cd14a39 Compare November 6, 2025 07:11

frank-king marked this pull request as ready for review November 6, 2025 09:11

rustbot assigned Nadrieril Nov 6, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 6, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 9, 2025

This comment has been minimized.

Sign in to view

Implement &pin patterns and ref pin bindings

5ef48ed

frank-king force-pushed the feature/pin-pattern branch from cd14a39 to 5ef48ed Compare November 10, 2025 02:04

traviscross approved these changes Nov 10, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2025

bors mentioned this pull request Nov 10, 2025

Add new function_casts_as_integer lint #141470

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 10, 2025

bors merged commit 29a6971 into rust-lang:main Nov 10, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 10, 2025

bors mentioned this pull request Nov 10, 2025

Add Drop::pin_drop for pinned drops #144537

Open

4 tasks

frank-king deleted the feature/pin-pattern branch November 10, 2025 23:23

Implement &pin patterns and ref pin binding modes #148397

Implement &pin patterns and ref pin binding modes #148397

Uh oh!

Conversation

frank-king commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Nov 6, 2025

Uh oh!

rustbot commented Nov 6, 2025

Uh oh!

rustbot commented Nov 6, 2025

Uh oh!

Nadrieril commented Nov 9, 2025

Uh oh!

bors commented Nov 9, 2025

Uh oh!

bors commented Nov 9, 2025

Uh oh!

bors commented Nov 9, 2025

Uh oh!

This comment has been minimized.

rustbot commented Nov 10, 2025

Uh oh!

frank-king commented Nov 10, 2025

Uh oh!

traviscross left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

traviscross commented Nov 10, 2025

Uh oh!

bors commented Nov 10, 2025

Uh oh!

bors commented Nov 10, 2025

Uh oh!

Nadrieril commented Nov 10, 2025

Uh oh!

bors commented Nov 10, 2025

Uh oh!

bors commented Nov 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 10, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 10, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Implement `&pin` patterns and `ref pin` binding modes #148397

Implement `&pin` patterns and `ref pin` binding modes #148397

frank-king commented Nov 2, 2025 •

edited

Loading

traviscross left a comment •

edited by rustbot

Loading